This repository has been archived by the owner on Jan 1, 2023. It is now read-only.
updated to work with twig formula loader changes #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ | |||
| "require": { | |||
| "php": ">=5.3.0", | |||
| "symfony/framework-bundle": ">=2.1.0,<2.3-dev", | |||
| "kriswallsmith/assetic": "1.1.*" | |||
| "kriswallsmith/assetic": "dev-node-visitor" | |||
There was a problem hiding this comment.
This needs to be reverted before the merge (btw, should we release 1.1 first and bump Assetic to 1.2 with these changes ?)
There was a problem hiding this comment.
What stability is 1.1 at?
There was a problem hiding this comment.
currently, we only have alpha releases for 1.1 (but doing a stable release would be a great idea)
There was a problem hiding this comment.
thus, changing the signature of the Twig extension is a BC break for everyone using Assetic and Twig standalone so I don't really like doing this before the 1.1 release
Files in the cache directory need to be removed in these static methods, otherwise Twig will see class_exists() return true in ->loadTemplate() and skip re-compiling because of that, but the node visitor's ConfigCache file for that template will be gone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility with kriswallsmith/assetic#338